If a disbeliever or apostate becomes Muslim but persists in committing a sin from which he has not repented, his becoming Muslim is valid according to scholarly consensus. But will he be forgiven for his sin from which he has not repented by virtue of becoming Muslim? Concerning that there are two scholarly views. See a detailed discussion of that in the long answer.